qemu formula missing spice

[mmartial]

Additional Info

• I am using Windows Subsystem for Linux

Output of brew config

HOMEBREW_VERSION: 4.2.16-111-g0476c2e
ORIGIN: https://github.com/Homebrew/brew
HEAD: 0476c2e5e4f02b409084553896340b2f4ab3352e
Last commit: 3 hours ago
Core tap HEAD: 1755d45c8945f9b1e8d4e2ef568f2ab7153623da
Core tap last commit: 4 hours ago
Core tap JSON: 07 Apr 02:00 UTC
HOMEBREW_PREFIX: /home/linuxbrew/.linuxbrew
HOMEBREW_CASK_OPTS: []
HOMEBREW_MAKE_JOBS: 48
HOMEBREW_SORBET_RUNTIME: set
Homebrew Ruby: 3.1.4 => /home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/portable-ruby/3.1.4/bin/ruby
CPU: 48-core 64-bit ivybridge
Clang: 17.0.6
Git: 2.34.1 => /bin/git
Curl: 7.81.0 => /bin/curl
Kernel: Linux 6.5.0-26-generic x86_64 GNU/Linux
OS: Ubuntu 22.04.4 LTS (jammy)
Host glibc: 2.35
/usr/bin/gcc: 11.4.0
/usr/bin/ruby: N/A
glibc: N/A
gcc@11: N/A
gcc: 13.2.0
xorg: N/A

Output of brew doctor

Warning: Some installed kegs have no formulae!
This means they were either deleted or installed manually.
You should find replacements for the following formulae:
  spice-server

Uncommitted files:
   M Formula/q/qemu.rb

Description of issue

qemu builds without support for spice

How to test: try running qemu-system-x86_64 [...] with -spice disable-ticketing=on,port=5930,addr=
will show that -splice is not a recognized option.

Why: qemu is not built with the --enable-splice option.

Tried to fix:

brew install qemu
brew remove qemu
brew tap —force homebrew/core
brew edit —formula qemu

Added --enable-spice to qemu.rb:

diff --git a/Formula/q/qemu.rb b/Formula/q/qemu.rb
index 415adc19af7..bf469208031 100644
--- a/Formula/q/qemu.rb
+++ b/Formula/q/qemu.rb
@@ -75,6 +75,7 @@ class Qemu < Formula
       --enable-curses
       --enable-fdt=system
       --enable-libssh
+      --enable-spice
       --enable-vde
       --enable-virtfs
       --enable-zstd

The build fails because

Run-time dependency spice-protocol found: YES 0.14.4
Run-time dependency spice-server found: NO (tried pkgconfig)
../meson.build:1024:10: ERROR: Dependency "spice-server" not found, tried pkgconfig

The spice source code is at https://gitlab.freedesktop.org/spice/spice

So I created a test spice-server.rb based on the qemu.rb file (removing macOS and bottles for now). spice-server.rb requires opus to build.

spice-server.rb:

class SpiceServer < Formula
  desc "Spice-Server"
  homepage "https://www.spice-space.org/"
  url "https://gitlab.freedesktop.org/spice/spice/uploads/29ef6b318d554e835a02e2141f888437/spice-0.15.2.tar.bz2"
  sha256 "6d9eb6117f03917471c4bc10004abecff48a79fb85eb85a1c45f023377015b81"
  head "https://gitlab.freedesktop.org/spice/spice.git", branch: "master"

  depends_on "libtool" => :build
  depends_on "meson" => :build
  depends_on "ninja" => :build
  depends_on "pkg-config" => :build
  depends_on "spice-protocol" => :build

  depends_on "capstone"
  depends_on "dtc"
  depends_on "glib"
  depends_on "gnutls"
  depends_on "jpeg-turbo"
  depends_on "libpng"
  depends_on "libslirp"
  depends_on "libssh"
  depends_on "libusb"
  depends_on "lzo"
  depends_on "ncurses"
  depends_on "nettle"
  depends_on "pixman"
  depends_on "snappy"
  depends_on "vde"
  depends_on "zstd"

  depends_on "opus"

  uses_from_macos "bison" => :build
  uses_from_macos "flex" => :build

  on_linux do
    depends_on "attr"
    depends_on "gtk+3"
    depends_on "libcap-ng"
  end

  fails_with gcc: "5"

  def install
    ENV["LIBTOOL"] = "glibtool"

    args = %W[
      --prefix=#{prefix}
    ]

    system "./configure", *args
    system "make", "install"
  end

end

brew install --build-from-source -v ./spice-server.r works

Trying to build qemu now pass the configure step and starts building until an error for a missing spice.h file

gcc-11 -m64 -mcx16 -Ilibcommon.fa.p -I../common-user/host/x86_64 -I../linux-user/include/host/x86_64 -I../linux-user/include -Iui -I../ui -I/home/linuxbrew/.linuxbrew/Cellar/capstone/5.0.1/include/capstone -I/home/linuxbrew/.linuxbrew/opt/zlib/include -I/home/linuxbrew/.linuxbrew/Cellar/libidn2/2.3.7/include -I/home/linuxbrew/.linuxbrew/Cellar/libtasn1/4.19.0/include -I/home/linuxbrew/.linuxbrew/Cellar/nettle/3.9.1/include -I/home/linuxbrew/.linuxbrew/Cellar/p11-kit/0.25.3/include/p11-kit-1 -I/home/linuxbrew/.linuxbrew/Cellar/gnutls/3.8.4/include -I/home/linuxbrew/.linuxbrew/Cellar/pixman/0.42.2/include/pixman-1 -I/home/linuxbrew/.linuxbrew/opt/libpng/include/libpng16 -I/home/linuxbrew/.linuxbrew/Cellar/pcre2/10.43/include -I/home/linuxbrew/.linuxbrew/Cellar/openssl@3/3.2.1/include -I/home/linuxbrew/.linuxbrew/Cellar/glib/2.80.0_2/include/glib-2.0 -I/home/linuxbrew/.linuxbrew/Cellar/glib/2.80.0_2/lib/glib-2.0/include -I/home/linuxbrew/.linuxbrew/Cellar/spice-protocol/0.14.4/include/spice-1 -I/home/linuxbrew/.linuxbrew/Cellar/spice-server/0.15.2/include/spice-server -I/home/linuxbrew/.linuxbrew/Cellar/jpeg-turbo/3.0.2/include -I/home/linuxbrew/.linuxbrew/Cellar/libxau/1.0.11/include -I/home/linuxbrew/.linuxbrew/Cellar/libxdmcp/1.1.5/include -I/home/linuxbrew/.linuxbrew/Cellar/libxcb/1.16.1/include -I/home/linuxbrew/.linuxbrew/Cellar/libx11/1.8.9/include -I/home/linuxbrew/.linuxbrew/Cellar/libxext/1.3.6/include -I/home/linuxbrew/.linuxbrew/Cellar/libxfixes/6.0.1/include -I/home/linuxbrew/.linuxbrew/Cellar/libxxf86vm/1.1.5/include -I/home/linuxbrew/.linuxbrew/Cellar/libdrm/2.4.120/include -I/home/linuxbrew/.linuxbrew/Cellar/libdrm/2.4.120/include/libdrm -I/home/linuxbrew/.linuxbrew/Cellar/mesa/24.0.4/include -I/home/linuxbrew/.linuxbrew/Cellar/libepoxy/1.5.10/include -I/home/linuxbrew/.linuxbrew/Cellar/xorgproto/2024.1/include -I/home/linuxbrew/.linuxbrew/Cellar/systemd/255.4/include -I/home/linuxbrew/.linuxbrew/Cellar/libusb/1.0.27/include/libusb-1.0 -I/home/linuxbrew/.linuxbrew/Cellar/libffi/3.4.6/include -I/home/linuxbrew/.linuxbrew/Cellar/util-linux/2.39.3/include/libmount -I/home/linuxbrew/.linuxbrew/Cellar/util-linux/2.39.3/include/blkid -I/home/linuxbrew/.linuxbrew/Cellar/glib/2.80.0_2/include -I/home/linuxbrew/.linuxbrew/Cellar/glib/2.80.0_2/include/gio-unix-2.0 -I/home/linuxbrew/.linuxbrew/opt/zstd/include -I/home/linuxbrew/.linuxbrew/Cellar/libslirp/4.7.0/include/slirp -I/home/linuxbrew/.linuxbrew/Cellar/ncurses/6.4/include/ncursesw -I/home/linuxbrew/.linuxbrew/Cellar/ncurses/6.4/include -I/home/linuxbrew/.linuxbrew/opt/bzip2/include -I/home/linuxbrew/.linuxbrew/Cellar/xz/5.4.6/include -I/home/linuxbrew/.linuxbrew/Cellar/expat/2.6.2/include -I/home/linuxbrew/.linuxbrew/Cellar/dbus/1.14.10/include/dbus-1.0 -I/home/linuxbrew/.linuxbrew/Cellar/dbus/1.14.10/lib/dbus-1.0/include -I/home/linuxbrew/.linuxbrew/Cellar/libxi/1.8.1/include -I/home/linuxbrew/.linuxbrew/Cellar/libxtst/1.2.4/include -I/home/linuxbrew/.linuxbrew/Cellar/at-spi2-core/2.52.0/include/at-spi2-atk/2.0 -I/home/linuxbrew/.linuxbrew/Cellar/at-spi2-core/2.52.0/include/at-spi-2.0 -I/home/linuxbrew/.linuxbrew/Cellar/at-spi2-core/2.52.0/include/atk-1.0 -I/home/linuxbrew/.linuxbrew/Cellar/libtiff/4.6.0/include -I/home/linuxbrew/.linuxbrew/Cellar/gdk-pixbuf/2.42.10_1/include/gdk-pixbuf-2.0 -I/home/linuxbrew/.linuxbrew/Cellar/libxrender/0.9.11/include -I/home/linuxbrew/.linuxbrew/Cellar/libxrandr/1.5.4/include -I/home/linuxbrew/.linuxbrew/Cellar/libxdamage/1.1.6/include -I/home/linuxbrew/.linuxbrew/Cellar/wayland/1.22.0/include -I/home/linuxbrew/.linuxbrew/Cellar/libxinerama/1.1.5/include -I/home/linuxbrew/.linuxbrew/opt/freetype/include/freetype2 -I/home/linuxbrew/.linuxbrew/Cellar/fontconfig/2.15.0/include -I/home/linuxbrew/.linuxbrew/Cellar/cairo/1.18.0/include -I/home/linuxbrew/.linuxbrew/Cellar/cairo/1.18.0/include/cairo -I/home/linuxbrew/.linuxbrew/Cellar/fribidi/1.0.13/include/fribidi -I/home/linuxbrew/.linuxbrew/Cellar/graphite2/1.3.14/include -I/home/linuxbrew/.linuxbrew/Cellar/harfbuzz/8.4.0/include/harfbuzz -I/home/linuxbrew/.linuxbrew/Cellar/pango/1.52.2/include/pango-1.0 -I/home/linuxbrew/.linuxbrew/Cellar/libxkbcommon/1.7.0/include -I/home/linuxbrew/.linuxbrew/Cellar/gtk+3/3.24.41/include/gtk-3.0 -fdiagnostics-color=auto -Wall -Winvalid-pch -std=gnu11 -O2 -g -fstack-protector-strong -Wundef -Wwrite-strings -Wmissing-prototypes -Wstrict-prototypes -Wredundant-decls -Wold-style-declaration -Wold-style-definition -Wtype-limits -Wformat-security -Wformat-y2k -Winit-self -Wignored-qualifiers -Wempty-body -Wnested-externs -Wendif-labels -Wexpansion-to-defined -Wimplicit-fallthrough=2 -Wmissing-format-attribute -Wno-missing-include-dirs -Wno-shift-negative-value -Wno-psabi -Wshadow=local -isystem /tmp/qemu-20240407-271069-zmchye/qemu-8.2.1/linux-headers -isystem linux-headers -iquote . -iquote /tmp/qemu-20240407-271069-zmchye/qemu-8.2.1 -iquote /tmp/qemu-20240407-271069-zmchye/qemu-8.2.1/include -iquote /tmp/qemu-20240407-271069-zmchye/qemu-8.2.1/host/include/x86_64 -iquote /tmp/qemu-20240407-271069-zmchye/qemu-8.2.1/host/include/generic -iquote /tmp/qemu-20240407-271069-zmchye/qemu-8.2.1/tcg/i386 -pthread -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -fno-strict-aliasing -fno-common -fwrapv -fPIE -D_DEFAULT_SOURCE -D_XOPEN_SOURCE=600 -DNCURSES_WIDECHAR=1 -MD -MQ libcommon.fa.p/ui_ui-qmp-cmds.c.o -MF libcommon.fa.p/ui_ui-qmp-cmds.c.o.d -o libcommon.fa.p/ui_ui-qmp-cmds.c.o -c ../ui/ui-qmp-cmds.c
In file included from /tmp/qemu-20240407-271069-zmchye/qemu-8.2.1/include/ui/qemu-spice.h:22,
/tmp/qemu-20240407-271069-zmchye/qemu-8.2.1/include/ui/qemu-spice-module.h:22:10: fatal error: spice.h: No such file or directory
   22 | #include <spice.h>

But that file is present in the /home/linuxbrew/.linuxbrew/Cellar/spice-server/0.15.2/include/spice-server directory which is -I

spice-audio.h  spice-char.h  spice-core.h  spice.h  spice-input.h  spice-migration.h  spice-qxl.h  spice-replay.h  spice-server.h  spice-version.h

I am unclear of the next step, if someone has some advice

[ZhongRuoyu]

You need to add a dependency on spice-server to qemu too (which requires spice-server.rb to be placed in the tap). Homebrew's compiler shims remove -I flags referencing paths from undeclared dependencies. You can see that by inspecting the compiler shims' logs (at ~/.cache/Homebrew/Logs/qemu on Linux by default; check the .cc files).

[mmartial]

Thank you, I have added depends_on "spice-server" => :build into the qemu.rb and am in the process of testing

[mmartial]

It did build. Thank you :)

My next step is to try to figure out how to contribute the changes upstream once I have confirmed it works.