Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve safety of strings used as paths #193

Open
hassila opened this issue Sep 27, 2023 · 1 comment
Open

Improve safety of strings used as paths #193

hassila opened this issue Sep 27, 2023 · 1 comment

Comments

@hassila
Copy link
Contributor

hassila commented Sep 27, 2023

So it works on e.g. Windows etc, some input here:

https://rdrr.io/cran/fs/src/R/sanitize.R
https://forums.swift.org/t/unsafe-characters-in-file-names-redux/65764

Should check swift-foundation if anything exists already and consider an extension to either system or swift-foundation or string for this.

cleanupStringForShellSafety should be replace with this new function.

@hassila
Copy link
Contributor Author

hassila commented Apr 16, 2024

Also for absolute threshold checks we don't seem to clean up the string properly (so benchmarks with spaces in the name fails - workaround is to use camel case).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant