Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HeapViewer] Displaying threads in Threads view is sometimes slow #574

Closed
thurka opened this issue May 10, 2024 · 2 comments
Closed

[HeapViewer] Displaying threads in Threads view is sometimes slow #574

thurka opened this issue May 10, 2024 · 2 comments
Assignees
@thurka
Labels
bug

Comments

@thurka
Copy link
Member

thurka commented May 10, 2024

This happens on heap dumps, which have a large number of running threads (>4000) and are taken on JDK 17 or older.
The most of the time is spent in org.graalvm.visualvm.heapviewer.java.impl.JavaThreadsProvider.isVirtualThread () - see attached snapshot: snapshot-1715328986105.nps.gz
@thurka thurka added the bug label May 10, 2024
@thurka thurka self-assigned this May 10, 2024
@thurka
Copy link
Member Author

thurka commented May 10, 2024

This is regression introduced by GH-539.

thurka added a commit that referenced this issue May 13, 2024
@thurka
GH-574 do not call heap.getJavaClassByName(java.lang.VirtualThread) i…
e0a6d6b 
…n the loop for every thread
@thurka
Copy link
Member Author

thurka commented May 13, 2024

Fixed in master.

@thurka thurka closed this as completed May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thurka thurka

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thurka