-
Notifications
You must be signed in to change notification settings - Fork 713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MutableSpan.clone isn't implemented #1429
Labels
Comments
I think this is also not relevant when all handlers read, but don't mutate, the span. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
MutableSpan.clone
isn't implemented. It was originally here for folks to transfer a mutable span to another thread when they weren't the end of the line ofSpanHandler
s.As no one noticed, it probably doesn't matter, but raising just in case someone cars.
workaround:
You can return false on
SpanHandler.end
after transferring your span to another thread meanwhile. Returning false will prevent a later handler from working on the same object, and has no harm in typical case where there is only one handler (span reporter) or that is at the end anyway.The text was updated successfully, but these errors were encountered: