-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Test our *2john tools #5433
Labels
testing
A testing task or issue (e.g., with CI)
Comments
Do we use self hosted github runners? |
No, we currently run CI jobs in GitHub and CircleCI infrastructure. I see no need for self-hosted for this task - testing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We need to start automatic testing of our
*2john
tools, perhaps on GitHub Actions using inputs from our https://github.com/openwall/john-samples repo. Most of these tools are Python scripts and some have dependencies, so this task might not be completed in one step. It's OK to start with testing our C compiled programs, then proceed to add more.Also, maybe some of this (not requiring large input files) should become part of our
make check
(and individual tests automatically skipped when dependencies are not satisfied? so thatmake check
remains usable to testjohn
itself everywhere it currently is).The text was updated successfully, but these errors were encountered: