-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JsonQueryObjectModelConverter#toJson: ignores QueryPart#addGuid #1255
Labels
Comments
Looks plausible. Thanks for reporting! Would you like to make a pull request? BIMserver/PluginBase/src/org/bimserver/database/queries/om/JsonQueryObjectModelConverter.java Lines 97 to 103 in 9c9d474
|
Thanks for the fast reply and follow-up! I'll follow-up with a PR. |
Read for review: #1257 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I believe the GUID filter of QueryPart is ignored.
To reproduce:
Problem analysis
The issue is that JsonQueryObjectModelConverter#toJson skips the QueryPart's GUID's.
Adding:
under the block processing the oids in the toJson method seems to resolve the issue.
The text was updated successfully, but these errors were encountered: