You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
in PrettyPrinterTest. As a consequence Spacing.NONE in line 271 can no longer be resolved. I don't know what issue the compiler has here, but apparently there is an edge case concerning enum imports. Other files are affected as well, but it is the same pattern there.
Groups and orders import statements. If a style has been defined, this recipe will order the imports according to that style. If no style is detected, this recipe will default to ordering imports in the same way that IntelliJ IDEA does.
Would you say those are the same case? Or do you think your use of a custom style factors in here as well?
What I like about that other issue is that we have a fairly simple unit test to replicate the issue there: #3283 (comment)
We just haven't yet gotten around to a fix of this particular issue, as it's hard to get to everything.
Do appreciate you calling this out! Definitely something we should fix to have a good experience running OrderImports.
What version of OpenRewrite are you using?
I am using
How are you running OpenRewrite?
I am using the Maven plugin, and my project is a single module project.
What is the
smallest, simplestway to reproduce the problem?This example is not minimal, but it is reproducible.
./gradlew publishToMavenLocal
mvn -P openrewrite org.openrewrite.maven:rewrite-maven-plugin:run
What did you see?
this change set: timo-a/jackson-core@c2970c0
are replaced with
in PrettyPrinterTest. As a consequence
Spacing.NONE
in line 271 can no longer be resolved. I don't know what issue the compiler has here, but apparently there is an edge case concerning enum imports. Other files are affected as well, but it is the same pattern there.extends
on new line is indentedExample: timo-a/jackson-core@c2970c0#diff-88fe5e2a29aa76eab8d3ec510f7aeb1ed3505a08c183f74e01543ff398ef7d0d
The docs only speak of ordering imports:
so this is unexpected.
Based on my style specification, I expect imports to be split in at most three groups: other, my explicitly defined package and static imports. However there is always (?) a blank line after java imports while not necessarily above it,
example: timo-a/jackson-core@c2970c0#diff-fc3028f1ae776b0c8a46f8cacd73ecad36c879df456fb575d69ff48f5a2c3291
Are you interested in contributing a fix to OpenRewrite?
no, just reporting
The text was updated successfully, but these errors were encountered: