-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MavenResolutionResult's ResolvedDependencies List Includes Excluded Dependencies #4126
Comments
Hi @matthew-js-porter ; Runnable tests are my absolute favorite way to receive a bug report, so thanks a lot for that! As to what causes this we'd have to look into this; and make sure any fix lines up with what recipes expect. I do notice you reported using rewrite-maven 8.11.5, whereas the latest version is 8.24.0, as managed through our rewrite-recipe-bom 2.10.0. Any reason you're still on an older version? Did you already look into what might cause us to report excluded dependencies as dependency? I'd welcome a draft PR with just the above test added to this project if you're up for it; that way we can tag-team on a possible fix. |
What version of OpenRewrite are you using?
I am using
How are you running OpenRewrite?
I am Running from a Junit Test
What is the smallest, simplest way to reproduce the problem?
LogMavenDependencies.kt
ShowExclusionIssueTest.kt
Run the test and observe the output
What did you expect to see?
A list of dependencies that did not include
org.apache.tomcat.embed:tomcat-embed-core
Are you interested in contributing a fix to OpenRewrite?
The text was updated successfully, but these errors were encountered: