Alarms: list of bugs and improvements

[DonWillems]

Bugs:

• User can create empty alarm
• User can switch to any source when creating an alarm manually
• Date time Modified shown when creating an alarm
• When sorting an empty table an error occurs
• Clicking the 'select all' checkmark results in an error
• Save button is enabled even if nothing changed when opening an existing alarm
• Sorting leads to error : This ChildPart has no parentNode and therefore cannot accept a value. This likely means the element
• containing the part was manipulated in an unsupported way outside of Lit's control such that the part's marker nodes were ejected from DOM. For example, setting the element's innerHTML or textContent can do this.
• When selecting an alarm on an asset page, the alarm opens. If afterwards the 'assets' tab is slected it opens the alarms overview page

[pierrekil]

Lat item still open, and added few more:

• When selecting an alarm on an asset page, the alarm opens. If afterwards the 'assets', 'rules' or 'map' tab is selected it opens the alarms overview page
• Select 'assigned to me' an create a new alarm. It shows all alarms although 'assigned to me' is still enabled
• Select one alarm with toggle on the left, select 'Assigned to me': overall selection shows 'V'; when unselecting 'Assigned to me' non of the alarms is selected but overal selection shows '-'.
• When sorting alarms, they are ordered in alphabetical order. You'ld expect ordering by step in the process. Add a number to the status to resolve if an alternative is not feasible (hidden character?)
• When an alarm page is open, switch realm. Alarm is still shown and you can also save it. Expected: show alarm list of selected realm or empty page
• Use alarm icon of alarm page also for rules icon at the right hand side
• Severity high should send email to assignee of an alarm on creation, and on it being assigned (? will this be annoying if you assign it to yourself as admin). If the alarm does not have an assignee on creation, the email should go to all users with write access to alarms.

[pierrekil]

Still working on the last item?

[DonWillems]

@NinaBianca

• When entering the page, the table sorting indicates it sorts by severity, but it doesn't. Its sorted by updated date, which is fine, but it should indicate that. So, by default sort by updated, and indicate that that is the case.
• I can't link assets to a manual alarm?
• Using the back button after selecting an alarm doesn't bring you back to the alarms table (even after going back twice and seeing the URL change).
• Same goes for the alarms button, if you press it while having an individual alarm selected, you aren't brought back to the table view.
• When I have write access I can't change the assignee of an issue. Only super users can do this or creators of the issue? You should be able to do that if you have write access (maybe I'm contradicting something I said before, sorry). Also the select just shows 'Assignee', not whom it is assigned to, while you can see that on the table.
• We need some more permission levels, because only having read doesn't make that much sense.
• Nice to have: since you know who created a manual alarm, this can be shown in that field when opening an alarm. e.g. source: "Manual (donwillems)"
• I'll make some small styling changes somewhere this week

[DonWillems]

Hi @NinaBianca I've pushed some styling changes, please review my commits. I will also deploy this update to test1 now

[MartinaeyNL]

@pierrekil asked me to review the PR, so will do that right away.

[MartinaeyNL]

Put a review down addressing some technical topics that need some work.

@DonWillems as this is more styling related it's up to you whether to close this issue or not.