(job) attributes saved to db can not be cleared

[vchlum]

PR #2592 led me to this issue.

I was able to catch this issue in version 19. As far as I can see, it is still in version 23.

The exit state should be cleared in svr_startjob(). Please see the proposed PR #2592. Once #2592 will be fixed, the cleared exit state should be saved to the database. Once the PBS server is restarted (after an attempt to clear the state), the cleared exit state seems to be back. It was cleared in the memory only.

I observed this situation in version 19:

# printjob 15179738 |grep Exit_status
Exit_status = -18
# qstat -f 15179738 |grep Exit_status
#

The cause of this problem seems to be the lines attributes = attributes || hstore($number::text[]) in db_*.c files.

Also, the proposed PR #2592 (the job_obit() part) helps to prevent the consequences of this bug. -> A job with a positive exit state will not rerun.