Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor css after snapshot testing #65

Open
1 of 24 tasks
openmindculture opened this issue Jan 3, 2022 · 0 comments
Open
1 of 24 tasks

refactor css after snapshot testing #65

openmindculture opened this issue Jan 3, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@openmindculture
Copy link
Owner

openmindculture commented Jan 3, 2022

As the maintainer of my own website, I want to keep the tools up to date and improve maintainability.

After not working on the site for a while, many tools have become outdated. Also, the codebase does not meet my current coding preferences anymore. Style sheets seem too chaotic, markup and content are mixed in a redundant way without leveraging modular possibilities of the static site generation system. And that system has seen two major upgrades meanwhile. While my site still runs on eleventy 0.x, there is a stable 2.0 release available.

None of those overdue changes should be done before increasing test coverage, including screenshot tests and possibly doing cross-browser end-to-end tests and audits.

  • improve test coverage
    • click journey both on desktop and on mobile, to check different menu versions
    • screenshot tests
    • cross-browser tests
    • audits
  • upgrade tools
    • upgrade PostCSS etc., test, adapt configuration
      • remove unnecessary diversity unless it makes sense
        • is there a good reason to use cssnano instead of postcss-minify?
    • upgrade stylelint etc., test, adapt configuration
    • upgrade eleventy (possible breaking changes from 0.x -> 2.0 !)
  • proceed with refactoring
    • check open issues and notes
    • more modular content structure
      • elements copied to _storybook should be components instead
      • tiles (projects / skills) should be components
    • refactor CSS
    • automate extracting critical CSS
    • automate image optimization
  • after snapshot testing (codecpt, see Testing Tools: Codecept Front-End Tests #42)
  • readability / maintainability / developer experience
    • -> specificity and ordering
    • -> refactor class names (BEM)
  • new css features with progressive enhancement (container, parent, aspect-ratio)

see trello card

@openmindculture openmindculture self-assigned this Jan 3, 2022
@openmindculture openmindculture added the enhancement New feature or request label Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant