Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is 'name_de' not a waste of space ? #769

Open
asianrider opened this issue Jan 22, 2020 · 5 comments · May be fixed by #928
Open

Is 'name_de' not a waste of space ? #769

asianrider opened this issue Jan 22, 2020 · 5 comments · May be fixed by #928

Comments

@asianrider
Copy link

I was wondering if this tag is relevant. I like the idea of having name_en available as English is the de facto OSM and international language, but, besides the fact that the original creators were german-speaking (kinda ;-), it seems like a waste of space as name:de is already available and coalescing can be made more easily at the SDK level (with mapbox sdk at least).

Danke für ihr Verständnis ;-)

@nyurik
Copy link
Member

nyurik commented Jan 22, 2020

While PBFs makes it very efficient to store repeated identical values (each unique string is stored only once), I was also thinking that we should remove those names that we had for historical reasons just for the sake of clarity and compactness. I don't even think we should have name_en -- we could have name_int (for latin-based international name), but all language-specific ones should be name:xx.

@asianrider
Copy link
Author

OK, I didn't know about this PBF optimization.
Yes, you're right, name_int is a better candidate for this. I can submit a PR if wanted.

@klokan
Copy link
Member

klokan commented Jun 2, 2020

This is a breaking change for schema 3.x - if merged and released - people who upgrade need to update their styles.

One of the things we wanted to do on 4.x schema change (in a semver style).

If to do that - then removing all "name_[language]" perhaps, not just "name_de" - as they are replaceable with "name:[language]" and name_int + name_latin.

@nyurik
Copy link
Member

nyurik commented Jun 2, 2020

I agree - we should remove name_en at the same time. What's more, I think we have some weird name:latin and name:nonlatin hack, which I think we should get rid of too -- name:xx should only be used by the real languages, and everything else like latinizated name should be using the underscore (i.e. name_latin).

Currently, the OMT-Tools add name:latin and name:nonlatin - see tileset.py and language.sql.

@ZeLonewolf
Copy link
Contributor

Can we add this to the milestone list for 4.0?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants