Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove env hack for invalidating run without invalidating mount cache #150

Open
coryb opened this issue May 19, 2020 · 0 comments
Open

Remove env hack for invalidating run without invalidating mount cache #150

coryb opened this issue May 19, 2020 · 0 comments
Labels
upstream Waiting for fix in an upstream dependency

Comments

@coryb
Copy link
Contributor

coryb commented May 19, 2020

A hack was introduced in #147 to add an environment variable to the llb.ExecOp when ignoreCache is used instead of using llb.IgnoreCache. The llb option has the undesired effect of also invalidating all cache associated with mounts, which is generallly not what users want in HLB.

There is an open issue in buildkit: moby/buildkit#1213

We should re-evaluate and remove this hack when the above issue is resolved.
@coryb coryb added the upstream Waiting for fix in an upstream dependency label May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
upstream Waiting for fix in an upstream dependency
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@coryb