Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add systemd cgroup path spec #1021

Open
AkihiroSuda opened this issue Nov 6, 2019 · 2 comments · May be fixed by #1115
Open

Add systemd cgroup path spec #1021

AkihiroSuda opened this issue Nov 6, 2019 · 2 comments · May be fixed by #1115

Comments

@AkihiroSuda
Copy link
Member

https://github.com/opencontainers/runtime-spec/blob/master/config-linux.md#cgroups-path

The systemd cgroup path convention implemented in runc/crun should be added to the spec.

This convention is becoming important for cgroup v2, because rootless containers depends on systemd for cgroup delegation in most environments.
@nimrodshn nimrodshn mentioned this issue May 29, 2021
Merged
kailun-qin added a commit to kailun-qin/runtime-spec that referenced this issue Aug 5, 2021
@kailun-qin
specs-go/config: add systemd cgroup support
32e5fd9 
The `--systemd-cgroup` flag and the systemd cgroup path convention
currently implemented in `runc/crun` should be added to the spec.

This patch adds in the spec:
* the option to enable systemd cgroup;
* the configs of systemd units and the containing slice to map to the
  cgroup tree.

Fixes opencontainers#1021

Signed-off-by: Kailun Qin <[email protected]>
@kailun-qin kailun-qin linked a pull request Aug 5, 2021 that will close this issue
Open
@kailun-qin
Copy link
Contributor

kailun-qin commented Aug 5, 2021 •
edited

Do we have any plan to move this forward? Thanks!

@AkihiroSuda
Copy link
Member Author

Thanks for opening #1115, but I meant adding proper spec for the existing implementation of systemd cgroupsPath, e.g. user.slice:nerdctl:deadbeef
https://github.com/containerd/nerdctl/blob/07c3ca23743308987aa3b26b1fb7b560804ff9a4/cmd/nerdctl/run_cgroup_linux.go#L53

I didn't mean adding new fields for systemd.

kailun-qin added a commit to kailun-qin/runtime-spec that referenced this issue Aug 6, 2021
@kailun-qin
config-linux: add systemd cgroup path convention
4716058 
The systemd cgroup path convention currently implemented in runtimes
like `runc/crun` should be added to the spec.

This patch adds the systemd cgroup convention for `Linux.CgroupsPath`
which is in the `slice:prefix:name` form and clarifies the detailed
usage.

Fixes opencontainers#1021

Signed-off-by: Kailun Qin <[email protected]>
kailun-qin added a commit to kailun-qin/runtime-spec that referenced this issue Sep 2, 2022
@kailun-qin
config-linux: add systemd cgroup path convention
8fe6eee 
The systemd cgroup path convention currently implemented in runtimes
like `runc/crun` should be added to the spec. For more information,
please kindly refer to e.g. runc systemd cgroup driver doc:
https://github.com/opencontainers/runc/blame/main/docs/systemd.md.

This patch adds the systemd cgroup convention for `Linux.CgroupsPath`
which is in the `slice:prefix:name` form and clarifies the detailed
usage.

Fixes opencontainers#1021

Signed-off-by: Kailun Qin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

config-linux: add systemd cgroup path convention kailun-qin/runtime-spec
2 participants
@AkihiroSuda @kailun-qin