Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.0.x.x] Ready for a new release 3.0.4.0 #13803

Open
mhcwebdesign opened this issue Mar 22, 2024 · 30 comments
Open

[3.0.x.x] Ready for a new release 3.0.4.0 #13803

mhcwebdesign opened this issue Mar 22, 2024 · 30 comments
Labels
3.0.x.x Affects the 3.0.x.x maintenance version

Comments

@mhcwebdesign
Copy link
Collaborator

Hi Daniel,

I think we are ready for another tagged release 3.0.4.0 of the 3.0.x.x branch.

We have added a number of security patches, and payment extension updates over the past few months.
See also https://forum.opencart.com/viewtopic.php?t=233153

Can you do please another tagged release please?

Thanks

@mhcwebdesign mhcwebdesign added the 3.0.x.x Affects the 3.0.x.x maintenance version label Mar 22, 2024
@danielkerr
Copy link
Member

sure

@mhcwebdesign
Copy link
Collaborator Author

sure

Thanks. Let us know when you are done with this.

We have already a number of OpenCart users waiting for this upcoming 3.0.4.0 release.

@mhcwebdesign
Copy link
Collaborator Author

Hi Daniel, when will you be able to do a tagged 3.0.4.0 release? It has some important security fixes, and some other bugfixes.

@rasulsh
Copy link

rasulsh commented Apr 7, 2024

Hi Daniel, when will you be able to do a tagged 3.0.4.0 release? It has some important security fixes, and some other bugfixes.

What security issues have been addressed in this version? Could you please mention the related commits?
Thank you.

@NicNiead
Copy link

NicNiead commented May 3, 2024

is it ready?

@IP-CAM
Copy link

IP-CAM commented May 3, 2024

It looks like it::
https://github.com/opencart/opencart/blob/3.0.x.x/upload/index.php

define('VERSION', '3.0.4.0');

oc_3040

@mhcwebdesign
Copy link
Collaborator Author

@danielkerr : I know you are busy, but when find a moment, can you please do a tagged release for the 3.0.4.0 ?
Thanks.

@NicNiead
Copy link

NicNiead commented May 6, 2024

https://github.com/opencart/opencart/tree/3.0.x.x @mhcwebdesign Hi Bro, is the version downloaded from this address now 3.0.4.0?

@mhcwebdesign
Copy link
Collaborator Author

https://github.com/opencart/opencart/tree/3.0.x.x @mhcwebdesign Hi Bro, is the version downloaded from this address now 3.0.4.0?

Yes

@NicNiead
Copy link

NicNiead commented May 6, 2024

@mhcwebdesign I'm about to upgrade it from 3.0.3.9, no changes to the database? Just need to overwrite the program. Will it be upgraded to 3.0.4.0?

@mhcwebdesign
Copy link
Collaborator Author

@mhcwebdesign I'm about to upgrade it from 3.0.3.9, no changes to the database? Just need to overwrite the program. Will it be upgraded to 3.0.4.0?

No DB changes.

@NicNiead
Copy link

NicNiead commented May 6, 2024

@mhcwebdesign Thank you

@opencart opencart deleted a comment from NicNiead May 10, 2024
@mhcwebdesign
Copy link
Collaborator Author

mhcwebdesign commented May 17, 2024

@danielkerr : Will you be able to do a tagged release soon for 3.0.4.0 from the https://github.com/opencart/opencart/tree/3.0.x.x please?

Also, I think the https://github.com/opencart/opencart/tree/3.0.x.x_Maintenance (which was released as 3.0.3.9 a while ago, shouldn't be there anymore as a 3.0.x.x_Maintenance, we'd expect any fixes for it to already be in 3.0.4.0.

@danielkerr
Copy link
Member

ok deleted

@TheCartpenter
Copy link
Contributor

OC v3.2.0.0 has been mostly maintained since the beginning. Will there be a release of that version soon, as well?

@JohnnyVega
Copy link
Contributor

Hi, guys

It would be logical to call the new version "3.1.0.0" instead of "3.0.4.0." Because PHP 8 support is a big change.

The name "3.0.4.0" is very similar to previous versions where there was no PHP 8 support. If this version name is left, there will be a lot of errors and confusion in the future, especially among buyers. But if you call the version "3.1.0.0" - it will be well visually distinguishable from previous versions and will be well remembered.

As a result, it turns out:

  • 3.0. x. x - PHP 7 support,
  • 3.1. x. x - PHP 8 support

It looks good, it reads well, it is clear, it is well remembered and buyers will not be confused.

I understand that perhaps not all the conditions are met in order to name version 3.1. But sometimes you need to move away from strict formalism in favor of common sense and better clarity. Because in the end it will be better for everyone.

With respect and hope for common sense.

@TheCartpenter
Copy link
Contributor

3.1.0.0 already exists in the OC downloads.

@mhcwebdesign
Copy link
Collaborator Author

@JohnnyVega : This was discussed on the OpenCart forum, and the majority decided to go for a 3.0.4.0, see https://forum.opencart.com/viewtopic.php?t=233153#p867162

@JohnnyVega
Copy link
Contributor

3.1.0.0 already exists in the OC downloads.

You are wrong. In any case, there is no version 3.1 or 3.1.x.x on opencart.com.

@TheCartpenter
Copy link
Contributor

Looks like the beta has been removed from the downloads list.

@JohnnyVega
Copy link
Contributor

@JohnnyVega : This was discussed on the OpenCart forum, and the majority decided to go for a 3.0.4.0, see https://forum.opencart.com/viewtopic.php?t=233153#p867162

Thanks for the link. I have read this topic and I am not saying that your arguments are not correct. I just offer a slightly different take on it. As one movie hero said: "Code is more like guidelines than actual rules.." )

As I said earlier, the third and fourth digits in the version are poorly remembered. But the first two digits in the version are remembered perfectly. Let's try to use it.

For example, instead of the memorable 2.4 notation, we use 2.3.0.2. Someone can, using memory and despite the documentation, quickly remember how 2.3.0.0 and 2.3.0.2 differ from each other? )) We, as a thrifty old mistress, save numbers. )

The first branch of opencart in numbering reached 1.6.x. The second version in the numbering reached 2.3.x. The third version in the numbering reached 3.0.x.

We can more often than now use two digits in the version instead of four digits - numbers are enough, there is no shortage of numbers.

@TheCartpenter
Copy link
Contributor

@JohnnyVega : This was discussed on the OpenCart forum, and the majority decided to go for a 3.0.4.0, see https://forum.opencart.com/viewtopic.php?t=233153#p867162

Thanks for the link. I have read this topic and I am not saying that your arguments are not correct. I just offer a slightly different take on it. As one movie hero said: "Code is more like guidelines than actual rules.." )

As I said earlier, the third and fourth digits in the version are poorly remembered. But the first two digits in the version are remembered perfectly. Let's try to use it.

For example, instead of the memorable 2.4 notation, we use 2.3.0.2. Someone can, using memory and despite the documentation, quickly remember how 2.3.0.0 and 2.3.0.2 differ from each other? )) We, as a thrifty old mistress, save numbers. )

The first branch of opencart in numbering reached 1.6.x. The second version in the numbering reached 2.3.x. The third version in the numbering reached 3.0.x.

We can more often than now use two digits in the version instead of four digits - numbers are enough, there is no shortage of numbers.

Except that memorization isn't needed, in this case. Users simply needs to copy and paste the version number from their admin footer or from the index.php file.

@danielkerr
Copy link
Member

0k fine will do today

@danielkerr
Copy link
Member

danielkerr commented May 20, 2024

actually who wants the job of preparing new releases for the old version
?

@TheCartpenter
Copy link
Contributor

actually who wants the job of preparing new releases for the old version ?

I do.

@NicNiead
Copy link

I have been using it for a while. I feel that version 3.0.3.8 is the most stable. For online sales systems, the most important thing is stability and plug-in compatibility. Nothing else matters.

@mhcwebdesign
Copy link
Collaborator Author

actually who wants the job of preparing new releases for the old version ?

I am happy to continue the 3.0.x.x maintenance and releases if that helps.

@mhcwebdesign
Copy link
Collaborator Author

I have been using it for a while. I feel that version 3.0.3.8 is the most stable. For online sales systems, the most important thing is stability and plug-in compatibility. Nothing else matters.

This was precisely the reason why we continued the 3.0.x.x line: 3.0.3.9 and 3.0.4.0 are based on 3.0.3.8, with just some more bugfixes and security patches, and added support for PHP 8.x.

@JohnnyVega
Copy link
Contributor

actually who wants the job of preparing new releases for the old version ?

I do.

@osworx
Copy link
Contributor

osworx commented May 21, 2024

I would recommend @mhcwebdesign - he has done a lot for that in the past, knows the code very well and is also well known in the OC community.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.0.x.x Affects the 3.0.x.x maintenance version
Projects
None yet
Development

No branches or pull requests

8 participants