-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Session stores old order id even if order was deleted, causing error on next checkout. #12800
Comments
did you clear all your cache? |
dont delete orders that have not been completed |
Maybe then they should not be deletable or only after some grace period? As said this rarely happens and likely is due to testing but still very hard to debug and not a nice UX for customers if they run into it. |
generally incomplete orders dont show in the admin ? |
they go to missing until and order status id has been added |
should be fixed now |
OpenCart 4.0.2.3
Describe the bug
Under certain rare circumstances the session stores an non-existing order id. If a user abandons checkout and an admin deletes that pending order in the meantime. If the user returns before their session expired the session will still pass that old (non existing) order id causing an error on checkout if the payment module relies on it.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
The cart should imo check if the order id still exists in the system at some point before processing the payment to make sure it does not error.
Server / Test environment (please complete the following information):
The text was updated successfully, but these errors were encountered: