Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Commits from serum after 29 Aug #8

Open
KirillLykov opened this issue Nov 18, 2022 · 3 comments
Open

Commits from serum after 29 Aug #8

KirillLykov opened this issue Nov 18, 2022 · 3 comments

Comments

@KirillLykov
Copy link
Contributor

It looks like 3 commits which were added to serum after 29 Aug were not added to openbook (https://github.com/project-serum/serum-dex/commits/master).
Could you clarify if it is for a reason or just two forks diverged?
@benchow
Copy link

benchow commented Nov 18, 2022 •
edited
Loading

What was mentioned in the telegram group.. the last 3 commits are just merged and not audited. It was forked from that commit because serum mainnet was on that commit.

@mschneider
Copy link
Contributor

The PR has been reopened on this github, so it can be reviewed. First comments are in, would appreciate if someone could start on getting it over the finish line: #1

@KirillLykov
Copy link
Contributor Author

The PR has been reopened on this github, so it can be reviewed. First comments are in, would appreciate if someone could start on getting it over the finish line: #1

@a-creation could you check out comments for #1 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mschneider @benchow @KirillLykov