Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.1.0 - Admin Page Only Allows Stopping Of Own Apps #496

Open
nik-humphries opened this issue May 21, 2024 · 1 comment
Open

3.1.0 - Admin Page Only Allows Stopping Of Own Apps #496

nik-humphries opened this issue May 21, 2024 · 1 comment
Labels
Milestone

Comments

@nik-humphries
Copy link

nik-humphries commented May 21, 2024

When using the admin page to stop an application, if the application was started by another user, it is not possible to stop it. A 403 on the API is returned.

Received invalid response (not 200 OK)  
Response {type: 'basic', url: 'https://xxx/ap…proxy/018cc2ab-348d-4765-bff5-9f1e0744f31a/status', redirected: false, status: 403, ok: false, …}

When closing your own applications, it works fine. Is this due to a change in authenticating against the API?
Everything was working fine in 3.0.2, but no longer in 3.1.0.

I haven't changed the admincontroller
I have added bootstrap to the html page

	<link media="screen" rel="stylesheet" href="https://cdn.jsdelivr.net/npm/[email protected]/dist/css/bootstrap.min.css" />
	<script src="https://cdn.jsdelivr.net/npm/[email protected]/dist/js/bootstrap.bundle.min.js"></script>
	<link rel="stylesheet" th:href="@{/assets/css/navbar.css}"/>
	<link rel="stylesheet" th:href="@{/assets/css/index.css}" />

The admin role is admins

In browser I am able to navigate via https://xxx/api/proxy/e97e7bba-384c-454f-b5c8-d3fef1138974/status but the PUT request 403's.

I can see that there doesn't appear to be a difference between the 2 requests in terms of cookies or auth headers, as they are both passing the session cookie.

Also to note we are using B2C / openid

Going to investigate some more.

@LEDfan LEDfan added the bug label May 21, 2024
@LEDfan
Copy link
Member

LEDfan commented May 21, 2024

Hi, thanks a lot for reporting this! This is a bug in the 3.1.0 release, we improved authorization in this release, but made it too strict for this part. We'll fix this soon and provide a snapshot version.

@LEDfan LEDfan added this to the Next milestone Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants