Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shinyproxy app images not loading due to unparsed function in image source #495

Closed
leynebe opened this issue May 21, 2024 · 2 comments
Closed
Labels

Comments

@leynebe
Copy link

leynebe commented May 21, 2024

Hi all!

Thanks for the big 3.1.0 release, there's a lot of new features we like.

I noticed that upon upgrade a lot of our app images are no longer loading. The HTML contains a function which I think shouldn't be there.

  • dev (3.1.0) image
    • If I remove the function part of it the image does load.
  • qa (3.0.x) image
    • Note that the image does work but I cannot show it.

I also noticed the following shinyproxy logs but I'm not sure it's related. I'm thinking maybe a template error occurs which causes the image's function to not be parsed/executed or something.

2024-05-21T12:36:49.720Z  WARN 1 --- [main] o.thymeleaf.templatemode.TemplateMode    : [THYMELEAF][main] Unknown Template Mode 'HTML5'. Must be one of: 'HTML', 'XML', 'TEXT', 'JAVASCRIPT', 'CSS', 'RAW'. Using default Template Mode 'HTML'.
2024-05-21T12:45:25.728Z  WARN 1 --- [ XNIO-1 task-12] actStandardFragmentInsertionTagProcessor : [THYMELEAF][XNIO-1 task-12][index] Deprecated unwrapped fragment expression "navbar :: navbar" found in template index, line 55, col 6. Please use the complete syntax of fragment expressions instead ("~{navbar :: navbar}"). The old, unwrapped syntax for fragment expressions will be removed in future versions of Thymeleaf.
2024-05-21T12:45:25.733Z  WARN 1 --- [ XNIO-1 task-12] o.t.s.p.StandardIncludeTagProcessor      : [THYMELEAF][XNIO-1 task-12][index] Deprecated attribute {th:include,data-th-include} found in template index, line 151, col 71. Please use {th:insert,data-th-insert} instead, this deprecated attribute will be removed in future versions of Thymeleaf.
2024-05-21T12:45:25.733Z  WARN 1 --- [ XNIO-1 task-12] actStandardFragmentInsertionTagProcessor : [THYMELEAF][XNIO-1 task-12][index] Deprecated unwrapped fragment expression "index :: app(${app})" found in template index, line 151, col 71. Please use the complete syntax of fragment expressions instead ("~{index :: app(${app})}"). The old, unwrapped syntax for fragment expressions will be removed in future versions of Thymeleaf.
2024-05-21T12:45:25.752Z  WARN 1 --- [ XNIO-1 task-12] o.t.s.p.StandardIncludeTagProcessor      : [THYMELEAF][XNIO-1 task-12][index] Deprecated attribute {th:include,data-th-include} found in template index, line 151, col 71. Please use {th:insert,data-th-insert} instead, this deprecated attribute will be removed in future versions of Thymeleaf.
2024-05-21T12:45:25.752Z  WARN 1 --- [ XNIO-1 task-12] actStandardFragmentInsertionTagProcessor : [THYMELEAF][XNIO-1 task-12][index] Deprecated unwrapped fragment expression "index :: app(${app})" found in template index, line 151, col 71. Please use the complete syntax of fragment expressions instead ("~{index :: app(${app})}"). The old, unwrapped syntax for fragment expressions will be removed in future versions of Thymeleaf.
2024-05-21T12:45:25.782Z  WARN 1 --- [ XNIO-1 task-12] o.t.s.p.StandardIncludeTagProcessor      : [THYMELEAF][XNIO-1 task-12][index] Deprecated attribute {th:include,data-th-include} found in template index, line 151, col 71. Please use {th:insert,data-th-insert} instead, this deprecated attribute will be removed in future versions of Thymeleaf.
2024-05-21T12:45:25.782Z  WARN 1 --- [ XNIO-1 task-12] actStandardFragmentInsertionTagProcessor : [THYMELEAF][XNIO-1 task-12][index] Deprecated unwrapped fragment expression "index :: app(${app})" found in template index, line 151, col 71. Please use the complete syntax of fragment expressions instead ("~{index :: app(${app})}"). The old, unwrapped syntax for fragment expressions will be removed in future versions of Thymeleaf.
2024-05-21T12:45:25.786Z  WARN 1 --- [ XNIO-1 task-12] o.t.s.p.StandardIncludeTagProcessor      : [THYMELEAF][XNIO-1 task-12][index] Deprecated attribute {th:include,data-th-include} found in template index, line 151, col 71. Please use {th:insert,data-th-insert} instead, this deprecated attribute will be removed in future versions of Thymeleaf.
2024-05-21T12:45:25.786Z  WARN 1 --- [ XNIO-1 task-12] actStandardFragmentInsertionTagProcessor : [THYMELEAF][XNIO-1 task-12][index] Deprecated unwrapped fragment expression "index :: app(${app})" found in template index, line 151, col 71. Please use the complete syntax of fragment expressions instead ("~{index :: app(${app})}"). The old, unwrapped syntax for fragment expressions will be removed in future versions of Thymeleaf.
2024-05-21T12:45:25.791Z  WARN 1 --- [ XNIO-1 task-12] o.t.s.p.StandardIncludeTagProcessor      : [THYMELEAF][XNIO-1 task-12][index] Deprecated attribute {th:include,data-th-include} found in template index, line 151, col 71. Please use {th:insert,data-th-insert} instead, this deprecated attribute will be removed in future versions of Thymeleaf.
2024-05-21T12:45:25.792Z  WARN 1 --- [ XNIO-1 task-12] actStandardFragmentInsertionTagProcessor : [THYMELEAF][XNIO-1 task-12][index] Deprecated unwrapped fragment expression "index :: app(${app})" found in template index, line 151, col 71. Please use the complete syntax of fragment expressions instead ("~{index :: app(${app})}"). The old, unwrapped syntax for fragment expressions will be removed in future versions of Thymeleaf.
2024-05-21T12:45:25.797Z  WARN 1 --- [ XNIO-1 task-12] o.t.s.p.StandardIncludeTagProcessor      : [THYMELEAF][XNIO-1 task-12][index] Deprecated attribute {th:include,data-th-include} found in template index, line 151, col 71. Please use {th:insert,data-th-insert} instead, this deprecated attribute will be removed in future versions of Thymeleaf.
2024-05-21T12:45:25.797Z  WARN 1 --- [ XNIO-1 task-12] actStandardFragmentInsertionTagProcessor : [THYMELEAF][XNIO-1 task-12][index] Deprecated unwrapped fragment expression "index :: app(${app})" found in template index, line 151, col 71. Please use the complete syntax of fragment expressions instead ("~{index :: app(${app})}"). The old, unwrapped syntax for fragment expressions will be removed in future versions of Thymeleaf.
2024-05-21T12:45:25.804Z  WARN 1 --- [ XNIO-1 task-12] o.t.s.p.StandardIncludeTagProcessor      : [THYMELEAF][XNIO-1 task-12][index] Deprecated attribute {th:include,data-th-include} found in template index, line 151, col 71. Please use {th:insert,data-th-insert} instead, this deprecated attribute will be removed in future versions of Thymeleaf.
2024-05-21T12:45:25.804Z  WARN 1 --- [ XNIO-1 task-12] actStandardFragmentInsertionTagProcessor : [THYMELEAF][XNIO-1 task-12][index] Deprecated unwrapped fragment expression "index :: app(${app})" found in template index, line 151, col 71. Please use the complete syntax of fragment expressions instead ("~{index :: app(${app})}"). The old, unwrapped syntax for fragment expressions will be removed in future versions of Thymeleaf.
2024-05-21T12:45:25.807Z  WARN 1 --- [ XNIO-1 task-12] o.t.s.p.StandardIncludeTagProcessor      : [THYMELEAF][XNIO-1 task-12][index] Deprecated attribute {th:include,data-th-include} found in template index, line 151, col 71. Please use {th:insert,data-th-insert} instead, this deprecated attribute will be removed in future versions of Thymeleaf.
2024-05-21T12:45:25.807Z  WARN 1 --- [ XNIO-1 task-12] actStandardFragmentInsertionTagProcessor : [THYMELEAF][XNIO-1 task-12][index] Deprecated unwrapped fragment expression "index :: app(${app})" found in template index, line 151, col 71. Please use the complete syntax of fragment expressions instead ("~{index :: app(${app})}"). The old, unwrapped syntax for fragment expressions will be removed in future versions of Thymeleaf.
2024-05-21T12:45:25.888Z  WARN 1 --- [ XNIO-1 task-12] o.t.s.p.StandardIncludeTagProcessor      : [THYMELEAF][XNIO-1 task-12][index] Deprecated attribute {th:include,data-th-include} found in template index, line 162, col 59. Please use {th:insert,data-th-insert} instead, this deprecated attribute will be removed in future versions of Thymeleaf.
2024-05-21T12:45:25.888Z  WARN 1 --- [ XNIO-1 task-12] actStandardFragmentInsertionTagProcessor : [THYMELEAF][XNIO-1 task-12][index] Deprecated unwrapped fragment expression "index :: app(${app})" found in template index, line 162, col 59. Please use the complete syntax of fragment expressions instead ("~{index :: app(${app})}"). The old, unwrapped syntax for fragment expressions will be removed in future versions of Thymeleaf.
2024-05-21T12:45:25.982Z  WARN 1 --- [ XNIO-1 task-12] actStandardFragmentInsertionTagProcessor : [THYMELEAF][XNIO-1 task-12][index] Deprecated unwrapped fragment expression "fragments/modal :: modal" found in template index, line 187, col 6. Please use the complete syntax of fragment expressions instead ("~{fragments/modal :: modal}"). The old, unwrapped syntax for fragment expressions will be removed in future versions of Thymeleaf.
2024-05-21T12:50:16.173Z  WARN 1 --- [ XNIO-1 task-14] actStandardFragmentInsertionTagProcessor : [THYMELEAF][XNIO-1 task-14][app] Deprecated unwrapped fragment expression "navbar :: navbar" found in template app, line 47, col 7. Please use the complete syntax of fragment expressions instead ("~{navbar :: navbar}"). The old, unwrapped syntax for fragment expressions will be removed in future versions of Thymeleaf.
2024-05-21T12:50:16.177Z  WARN 1 --- [ XNIO-1 task-14] actStandardFragmentInsertionTagProcessor : [THYMELEAF][XNIO-1 task-14][app] Deprecated unwrapped fragment expression "fragments/modal :: modal" found in template app, line 158, col 7. Please use the complete syntax of fragment expressions instead ("~{fragments/modal :: modal}"). The old, unwrapped syntax for fragment expressions will be removed in future versions of Thymeleaf.

And this is already covered by this ticket: #494

@LEDfan
Copy link
Member

LEDfan commented May 21, 2024

Hi, in order to make the new features possible, the HTML templates are changed. Please make sure to upgrade your templates (see https://github.com/openanalytics/shinyproxy-config-examples/tree/master/04-custom-html-template#where-to-find-the-original-template-files)

@leynebe
Copy link
Author

leynebe commented Jun 11, 2024

I totally missed these templates, this will fix it. Thanks a bunch!

@leynebe leynebe closed this as completed Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants