You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Attributes (a list of attribute keys) is the recommended set of attribute keys to be used for the resulting metrics.
Which gives very little context on what adding that list of attribute keys accomplishes from a user perspective. From reading the SDK spec, we get more implementation details that reveal that this is actually an allow-list of attribute keys, but only hidden inside the SDK spec for Views
I think we should clarify the API specification to indicate that this is an allow-list. Happy to open a PR if the Spec SIG agrees. 🙂
What are you trying to achieve?
The Metrics API specification for the
Attributes
instrument advisory parameters reads:Which gives very little context on what adding that list of attribute keys accomplishes from a user perspective. From reading the SDK spec, we get more implementation details that reveal that this is actually an allow-list of attribute keys, but only hidden inside the SDK spec for
View
sI think we should clarify the API specification to indicate that this is an allow-list. Happy to open a PR if the Spec SIG agrees. 🙂
Additional context.
opentelemetry-specification/specification/metrics/api.md
Lines 272 to 279 in 6360b49
opentelemetry-specification/specification/metrics/sdk.md
Lines 372 to 375 in 6360b49
The text was updated successfully, but these errors were encountered: