Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify Attributes instrument advisory parameter #4037

Open
pichlermarc opened this issue May 7, 2024 · 1 comment
Open

Clarify Attributes instrument advisory parameter #4037

pichlermarc opened this issue May 7, 2024 · 1 comment
Labels
spec:metrics Related to the specification/metrics directory triage:accepted:ready

Comments

@pichlermarc
Copy link
Member

What are you trying to achieve?

The Metrics API specification for the Attributes instrument advisory parameters reads:

Applies to all instrument types.

Attributes (a list of attribute keys) is the recommended set of attribute keys to be used for the resulting metrics.

Which gives very little context on what adding that list of attribute keys accomplishes from a user perspective. From reading the SDK spec, we get more implementation details that reveal that this is actually an allow-list of attribute keys, but only hidden inside the SDK spec for Views

I think we should clarify the API specification to indicate that this is an allow-list. Happy to open a PR if the Spec SIG agrees. 🙂

Additional context.

@trask
Copy link
Member

trask commented May 7, 2024

hi @pichlermarc, a clarification PR sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec:metrics Related to the specification/metrics directory triage:accepted:ready
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants