You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The SDK currently has a dependency on ordered_float. It is used to provide Hash, PartialEq implementations, for F64 values. While the crate is very popular, it is still a 3rd party dependency, maintained under a personal account.
Proposing to remove the dependency, and make Hash/PartialEq implementation in the opentelemetry crate itself, where Value is defined.
The "correctness" part is not very important - i.e it is undefined if the following would get aggregated into a single metric point or not.
The SDK currently has a dependency on ordered_float. It is used to provide Hash, PartialEq implementations, for
F64
values. While the crate is very popular, it is still a 3rd party dependency, maintained under a personal account.Proposing to remove the dependency, and make
Hash
/PartialEq
implementation in theopentelemetry
crate itself, whereValue
is defined.The "correctness" part is not very important - i.e it is undefined if the following would get aggregated into a single metric point or not.
As a bonus, we can avoid the
HashKeyValue
wrapper aroundKeyValue
used in Metrics, which solely exist today to provide hash/partialeq implementations.The text was updated successfully, but these errors were encountered: