Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What should provider's force_flush return #1751

Open
cijothomas opened this issue May 13, 2024 · 1 comment
Open

What should provider's force_flush return #1751

cijothomas opened this issue May 13, 2024 · 1 comment
Labels
A-common Area:common issues that not related to specific pillar help wanted Good for taking. Extra help will be provided by maintainers/approvers

Comments

@cijothomas
Copy link
Member

cijothomas commented May 13, 2024

We can return an overall Result
Return a Vec of results from each processor/reader.

We need to be consistent across signals, unless there is a good reason to deviate.

originally discussed in : #1750 (comment)

@cijothomas cijothomas added A-common Area:common issues that not related to specific pillar help wanted Good for taking. Extra help will be provided by maintainers/approvers labels May 13, 2024
@cijothomas
Copy link
Member Author

From SIG meeting on 5/14

Make force_flush return Vec! of Results from each processor (logs,traces), reader (metrics).
The order in which processors are invoked are not guaranteed. (explicitly document this)
The error message should be standardized so it'll be possible to tell which processor/reader is failed.
Failing to flush one should not affect the rest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-common Area:common issues that not related to specific pillar help wanted Good for taking. Extra help will be provided by maintainers/approvers
Projects
None yet
Development

No branches or pull requests

1 participant