-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
otel-appender-tracing can suppress other tracing layers #1682
Comments
Haven't tested this, but I believe the effect of |
Well, that is not the case! Any layer returning false would affect entire layers! (or the first layer that returns false, would cause the rest of the layers to be bypassed completely) |
True, did a quick test by modifying the example by adding a console-layer after otel-bridge layer, and forcing event_enabled to be false for otel-bridge - https://github.com/open-telemetry/opentelemetry-rust/compare/main...lalitb:test-multiple-layers?expand=1. The console-layer is not processed. |
From the
|
With
logs_level_enabled
feature, the appender-tracing returns false onevent_enabled
if it has no interest in the event. But this causes other layers, like afmt
layer to also miss the events. Lack of interest for otel layer should not influence other layers.I believe the solution should be to rewrite the
logs_level_enabled
to use https://docs.rs/tracing-subscriber/latest/tracing_subscriber/layer/index.html#per-layer-filteringThe text was updated successfully, but these errors were encountered: