-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
otlp+json enums should be integers #978
Labels
blocked
this issue is blocked by another issue.
pinned
Will not be removed by stalebot
Work In Progress
This is a Work in Progress, not ready to be merged
Comments
PR against google/protobuf to allow formatting enums as strings for JSON output: protocolbuffers/protobuf#12707 |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Note that this has been worked around via #1192 until protobuf changes are accepted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
blocked
this issue is blocked by another issue.
pinned
Will not be removed by stalebot
Work In Progress
This is a Work in Progress, not ready to be merged
The otel collector currently accepts the string values of ENUMs for json-encoded payloads, but this is now prohibited and will likely be removed in a future collector release:
We currently use protobuf's
serializeToJsonString()
method to generate JSON payloads, which doesn't expose any options to represent enums as their integer values.Possible solutions:
Additional context
Protobuf Ruby seems to support FormatEnumsAsIntegers
There is a partial implementation in the protobuf php extension for FormatEnumsAsIntegers, but it is not exposed via any public interfaces (and not available in the native library)
Tasks:
ProtobufSerializer
to send new flag(s)The text was updated successfully, but these errors were encountered: