Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Symfony auto-instrumentation] Messenger instrumentation should use SpanKind::KIND_PRODUCER, SpanKind::KIND_CONSUMER #1314

Open
dkarlovi opened this issue May 20, 2024 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers help wanted This issue is looking for someone to work on it

Comments

@dkarlovi
Copy link
Contributor

dkarlovi commented May 20, 2024

Steps to reproduce

Enable Symfony auto-instrumentation with default setup.

What is the expected behavior?

Spans when creating the message should be marked with SpanKind::KIND_PRODUCER.

Spans when handling the message should be marked with SpanKind::KIND_CONSUMER.

https://opentelemetry.io/docs/specs/semconv/messaging/messaging-spans/#span-kind

What is the actual behavior?

Everything is marked KIND_INTERNAL and it seems the consumer is currently not instrumented at all (I might be wrong here, please feel free to correct me).

Additionally, it seems to me the names of the spans are also not correct, as shown in the table in the spec linked above?

@dkarlovi dkarlovi added the bug Something isn't working label May 20, 2024
@agoallikmaa agoallikmaa added help wanted This issue is looking for someone to work on it good first issue Good for newcomers labels May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted This issue is looking for someone to work on it
Projects
None yet
Development

No branches or pull requests

2 participants