-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[opentelemetry-php-instrumentation] schema_url with fixed value #1312
Comments
Previous discussions:
Tl;dr: fixed schema urls should be used instead of |
https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/telemetry-stability.md#schema-file-driven-telemetry-producers - any of our instrumentations that are stable should have a fixed schema URL set, and it must not change (even if the semconv version does). So, I think that there's a task to go through our existing instrumentations to ensure that they do have a schema url set, and that it's fixed. Anything that's <= |
I will perform an analysis on contrib packages lower than |
Hello everyone, I currently identified that the auto-instrumentation packages (PSR-6 and Slim) incorporate the
schema_url
value with a fixed value, as shown in this code.However, the packages install the latest version of
open-telemetry/sem-conv
, which can become a problem in these cases where the value is fixed.I would like to suggest the following changes:
TraceAttributes::SCHEMA_URL
constant instead of a fixed value. Similar to what happens in the Guzzle packages, as shown in this code.TraceAttributes::SCHEMA_URL
in instrumentation.The text was updated successfully, but these errors were encountered: