-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[open-telemetry/transport-grpc] Endpoint has to contain scheme, host and path #1157
Comments
You are using What path did you add to the address when it complained about service name? I'm using the collector rather than straight to jaeger, but it looks happy with this value: |
Thank you, the path you mentioned works. It wasn't exactly clear to me from the documentation how to set up the path. |
@brettmc However, I'm still confused about this, I'm now testing the implementation directly with the collector: env:
OTEL config:
container
At this setting, it will return to me:
If, on the other hand, I use a generic endpoint as you suggested, I get:
|
To use the generic endpoint, you must put it in the
This is an interesting error. AFAICT, it means that a successful grpc connection was made (ie, to |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
If I use the gRPC protocol in conjunction with Jaeger (direct export without collector), according to the documentation it should be enough to use the address without path (https://opentelemetry.io/docs/instrumentation/php/exporters/).
However, without path it will not pass the validation in grpcTransportFactory:
if (substr_count($parts['path'], '/') !== 2) { throw new InvalidArgumentException(sprintf('Endpoint path is not a valid GRPC method "%s"', $method)); }
On the other hand, when I add path to the address, it fails on the fact that it doesn't know the service name. However the service for Jaeger should be created automatically.
My env settings:
OTEL_PHP_AUTOLOAD_ENABLED=true OTEL_TRACES_EXPORTER=otlp OTEL_METRICS_EXPORTER=none OTEL_LOGS_EXPORTER=none OTEL_EXPORTER_OTLP_PROTOCOL=grpc OTEL_EXPORTER_OTLP_TRACES_ENDPOINT="http://jaeger:14250" OTEL_PROPAGATORS=baggage,tracecontext
The text was updated successfully, but these errors were encountered: