Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support PriorityClass for target-allocator Pod #2980

Open
mdietzer-fn opened this issue May 21, 2024 · 1 comment
Open

Add support PriorityClass for target-allocator Pod #2980

mdietzer-fn opened this issue May 21, 2024 · 1 comment
Labels
area:target-allocator Issues for target-allocator enhancement New feature or request

Comments

@mdietzer-fn
Copy link

Component(s)

target allocator

Is your feature request related to a problem? Please describe.

We would like to set a PriorityClass for all of our OpenTelemetry Pods. Most pods objects/configs support this via priorityClassName. However, the TargetAllocator spec does not seem to include priorityClassName as a possible field.

Setting priorityClassName on an opentelemetry.io/v1beta1:OpenTelemetryCollector gives the collector itself the priority class, but if the targetAllocator is enabled within this object, it does not inherit this priority class, so there is no way to configure it.

Describe the solution you'd like

Add priorityClassName to the target allocator spec such that it can have a priority class configured or inherit priority class from the main OpenTelemetryCollector object.

Describe alternatives you've considered

No response

Additional context

No response

@mdietzer-fn mdietzer-fn added enhancement New feature or request needs triage labels May 21, 2024
@pavolloffay pavolloffay added area:target-allocator Issues for target-allocator and removed needs triage labels May 22, 2024
@swiatekm-sumo
Copy link
Contributor

Rather than add new fields to the embedded target allocator subresource in the OpenTelemetryCollector CR, we want to introduce a separate TargetAllocator CRD, which would have the same infrastructure related fields OpenTelemetryCollector has. The reason for this is that the collector CR is already quite big, and doubling all of these fields will make it even more so, which leads to various problems.

See #2422 for progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:target-allocator Issues for target-allocator enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants