Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BaggagePropagator] Do not encode and decode keys #5479

Open
pellared opened this issue Mar 27, 2024 · 0 comments · May be fixed by #5647
Open

[BaggagePropagator] Do not encode and decode keys #5479

pellared opened this issue Mar 27, 2024 · 0 comments · May be fixed by #5647
Labels
bug Something isn't working pkg:OpenTelemetry.Api Issues related to OpenTelemetry.Api NuGet package

Comments

@pellared
Copy link
Member

pellared commented Mar 27, 2024 •
edited

According to the spec only the value should be encoded.

The key is not expected to be percent encoded. More:

If the key is not W3C Baggage spec compliant then key-value pair must not be propagated and a warning should be emitted.
@pellared pellared mentioned this issue Mar 27, 2024
Merged
4 tasks
@reyang reyang added bug Something isn't working pkg:OpenTelemetry.Api Issues related to OpenTelemetry.Api NuGet package labels May 21, 2024
@lachmatt lachmatt linked a pull request May 23, 2024 that will close this issue
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working pkg:OpenTelemetry.Api Issues related to OpenTelemetry.Api NuGet package
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[baggage] validate key and values during baggage injection/extraction lachmatt/opentelemetry-dotnet
2 participants
@pellared @reyang