-
Notifications
You must be signed in to change notification settings - Fork 827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make it possible to disable OpenTelemetry Instrumentation #650
Labels
enhancement
New feature or request
telemetry
issues that relate to the telemetry generated by the demo
Comments
follow up on this, I have played around with this in this branch:
|
This seems like a bug in the node.js sample. |
austinlparker
added
v1.4
required for 1.4 release
telemetry
issues that relate to the telemetry generated by the demo
labels
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
telemetry
issues that relate to the telemetry generated by the demo
Feature Request
Is your feature request related to a problem?
#589, #606 and some other issues ask for the capability to autoinstrument services, especially by using the otel operator which comes with the capability to inject Automatic Instrumentation. While creating new services which are then auto instrumented is a possibility, I'd like to propose another solution:
By making it possibile to disable manual OpenTelemetry instrumentation, it would be possible to apply injected automatic instrumentation via the operator instead.
This not only removes the need to add even more services, it also allows has a few other benefits:
Describe the solution you'd like:
My naive assumption is that this might be fairly easy to implement:
OTEL_DO_NOT_INSTRUMENT="true"
if(!env.OTEL_DO_NOT_INSTRUMENT) { intializeSDK(); }
)The text was updated successfully, but these errors were encountered: