-
Notifications
You must be signed in to change notification settings - Fork 827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider using k8s workload name as the service.name #1423
Comments
To confirm I'm reading that code correctly, it uses the K8s Deployment name for the |
There was a similar discussion in this now closed PR on semantic-conventions. We were looking at a different set of standard labels in the PR than the ones being discussed here. We should create a new issue to discuss this in semantic-conventions but this might be a little difficult to standardize on given the number of options. Re: what should be our recommended way of getting the |
I wonder if part of the problem here is we have the Chart's release name as a prefix to every service name. If we remove that, we would more closely align with each component's service name being the same as the deployment name. |
Feature Request
This may be a question for semantic conventions, but I figured I would start here.
The k8s demo currently uses the
app.kubernetes.io/component
label as theservice.name
resource attribute:opentelemetry-demo/kubernetes/opentelemetry-demo.yaml
Lines 9727 to 9731 in 14bc74a
This differs from the behavior of the OpenTelemetry Operator, which uses the workload (deployment, statefulset, etc.) name as the
service.name
resource attributeIt would be nice if there was a standard way to default the service name in k8s environments which was used in the operator and in the k8s demo.
@open-telemetry/semconv-k8s-approvers
The text was updated successfully, but these errors were encountered: