-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[confignet] Should TransportType
unmarshal be case insensitive?
#10032
Comments
We can do this after 1.0, right? As long as the error message is clear, I don't think there is a need to do this right now |
I think it could wait until after 1.0 according to our version controls:
|
Oki, I am going to remove from the 1.0 milestone then (we can still do it now, just want to make it clear this is not a blocker for 1.0) |
Is your feature request related to a problem? Please describe.
Came across a situation in Contrib where the
TransportType
could not be used because the exporter supportedtcp
orTCP
, but theTransportType
unmarshal expects lowercase only.open-telemetry/opentelemetry-collector-contrib#32379 (comment)
Describe the solution you'd like
Should we consider treating the strings we're unmarshalling as case insensitive?
The text was updated successfully, but these errors were encountered: