-
-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gRPC does not work if proto contains imports (and fails on simple case) #272
Comments
@rogchap thank you for the detailed feedback! We greatly appreciate that you tested several use cases and described your issues so thoroughly. I believe the first issue you mentioned is failing because there are no defined properties in the message type named "Empty". We should be able to fix that shortly and we should add it to our testing cases. Support for importing files from within the proto files may take a bit longer to implement, but we will start working on it. I would say the same for custom options at this time, but we will put in some research and possibly follow-up with some more questions for you depending on what we find. |
Describe the bug
I was unable to get a simple gRPC example working. There also seems to be issues if you import any messages and also does not work with any well known proto types eg.
google.protobuf.Timestamp
To Reproduce
Simple proto causes this error when trying to select a request from the dropdown:
Also any proto that has an import statement will fail to read the methods:
Expected behavior
The first example shoud "just work", and the error message does not give me any information on what the problem is.
import statements should be followed and well known types should be automatically discovered. Most gRPC tools allow you to specify multiple proto files and also reference folders on where to read other imported files.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):
Additional context
More testing is required around gRPC to make this useful beyond the very simple case.
I also make use of custom options in my gRPC services, which also may cause issues with your custom parser eg:
The text was updated successfully, but these errors were encountered: