Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: repo not found [oven-sh/bun] #425

Open
cjfinnell opened this issue Dec 9, 2022 · 4 comments
Open

fix: repo not found [oven-sh/bun] #425

cjfinnell opened this issue Dec 9, 2022 · 4 comments

Comments

@cjfinnell
Copy link

When loading https://hot.opensauced.pizza/ I see:
Screen Shot 2022-12-09 at 08 36 12

Network shows 404s abound!

@NsdHSO
Copy link
Contributor

NsdHSO commented Dec 9, 2022

@0-vortex please take a look

@0-vortex
Copy link
Contributor

@0-vortex please take a look

Sorry for not answering earlier, due to how actions crawls over existing user stars in app.openauced, we were iterating over the user installation ids and re-creating the repository object without fetching all of the data again from the github api - this caused the oven-sh/bun repo to appear as Jarred-Sumner/bun. This error occurs in https://github.com/open-sauced/actions/blob/main/hot-supabase/user-stars.js#L176

A permanent fix for this will come soon, however, to protect ourselves from this kind of issue, we should have the top 3 promoted repositories listed by github id instead of full name! 😅 🍕

@cjfinnell
Copy link
Author

Checked again today and the observed issue is taken care of - thanks!

Screen Shot 2022-12-16 at 09 12 36

@mtfoley
Copy link
Contributor

mtfoley commented Jan 9, 2023

@0-vortex would a feasible fix to what you described involve changing these lines so that they use the fetchedRepo variable rather than the full name that was the basis of fetching? Since the rest API redirects, seems like this could be fixed on the fly, and all of the other properties used the fetchedRepo variable.
https://github.com/open-sauced/actions/blob/main/hot-supabase/user-stars.js#L194-L195

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants