Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Production site's repository list section, upvoting is not working. #385

Open
2 tasks done
janie-lee-developer opened this issue Oct 24, 2022 · 3 comments
Open
2 tasks done
Labels
🐛 bug Something isn't working

Comments

@janie-lee-developer
Copy link
Contributor

janie-lee-developer commented Oct 24, 2022

Describe the bug

At production branch, popular repositories section's upvote is not working. We find 406 error on the console when we try to upvote at the popular repositories section. This error is found while reviewing #384 PR.
@bdougie @0-vortex

Screen Shot 2022-10-24 at 3 18 39 PM

Steps to reproduce

  1. Go to production site, hot sauced.
  2. Go to Popular Repositories section.
  3. Click upvote on one of the popular repositories.
  4. Check console to find the error message.

Affected services

hot.opensauced.pizza

Platforms

No response

Browsers

No response

Environment

No response

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct

Contributing Docs

  • I agree to follow this project's Contribution Docs
@janie-lee-developer janie-lee-developer added the 🐛 bug Something isn't working label Oct 24, 2022
@0-vortex
Copy link
Contributor

Hello, I checked and there are a couple of things wrong:

  • PR feat: myVotes filter for repo list #384 is not released, so checking the production site is meaningless for review
  • the production site is currently using SupaBase SDK and there is an error in the console
  • but voting actually works

@bdougie bdougie changed the title Bug: Production site's popular repositories section, upvote is not working. Bug: Production site's repository list section, upvoting is not working. Oct 24, 2022
@bdougie
Copy link
Member

bdougie commented Oct 24, 2022

PR #384 is not released, so checking the production site is meaningless for review

@0-vortex, I am getting a 406 when voting on the deploy preview. @Deadreyo can vote via localhost on his branch. Filtering works on #384, so I will provide my approval for that, but perhaps we should move towards using the API for voting altogether.

@0-vortex
Copy link
Contributor

0-vortex commented Oct 24, 2022

PR #384 is not released, so checking the production site is meaningless for review

@0-vortex, I am getting a 406 when voting on the deploy preview. @Deadreyo can vote via localhost on his branch. Filtering works on #384, so I will provide my approval for that, but perhaps we should move towards using the API for voting altogether.

That's #372 at work, mainly because I had to change all org envs to the new system: https://docs.netlify.com/netlify-labs/experimental-features/environment-variables/

Currently, env reflects this (left is hot, right is api link):

  • localhost -> dev.api
  • beta -> dev.api
  • production -> prod.api
  • preview -> prod.api

Deploy preview still needs fixing :<

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants