Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activity feed bugs and improvements #16343

Open
3 tasks
aniketkatkar97 opened this issue May 20, 2024 · 11 comments · May be fixed by #16474
Open
3 tasks

Activity feed bugs and improvements #16343

aniketkatkar97 opened this issue May 20, 2024 · 11 comments · May be fixed by #16474
Assignees
Labels
UI UI specific issues

Comments

@aniketkatkar97
Copy link
Member

aniketkatkar97 commented May 20, 2024

Affected module
UI

Describe the bug

  • Activity tab reloads when commented in the thread resetting the selected thread. Prevent the reload and only update the selected thread
Screen.Recording.2024-05-20.at.11.21.19.AM.mov
  • persona update feed
Screen.Recording.2024-05-23.at.2.59.06.PM.mov
  • plus minus icons should be center aligned.
    image

Version:

  • OS: [e.g. iOS]
  • Python version:
  • OpenMetadata version: [e.g. 0.8]
  • OpenMetadata Ingestion package version: [e.g. openmetadata-ingestion[docker]==XYZ]

Additional context
Add any other context about the problem here.

@aniketkatkar97 aniketkatkar97 added the UI UI specific issues label May 20, 2024
@aniketkatkar97 aniketkatkar97 self-assigned this May 20, 2024
@ayush-shah
Copy link
Member

Incident Manager shows empty but the breadcrumb shows incident manager
Image 1) I see Incident Manager for successful test case
Image 2) On clicking Incident Manager on the breadcrumbs from Image 1, i get to see empty incident manager
Image 3) I got to Image 1 page from Activity feed shown in this image

Screenshot 2024-05-23 at 3 51 47 PM Screenshot 2024-05-23 at 3 52 05 PM

image

@harshach
Copy link
Collaborator

  • dashboard display needs to be shown
    image

  • it looks like activity feed is repeating for a failed test case result? the asset link at the top taking it
    image

  • align + icon with description
    image

@aniketkatkar97
Copy link
Member Author

  • Long description overflow
    image

@harshach
Copy link
Collaborator

  • Parse Test Case changes to show case what exactly is updated instead of json payload
image
  • span classes in description need to be rendered
image
  • what are we rendering in test case results, only failed test graph should be shown if the tests are passing we will show the metrics cc @mohityadav766
image
  • Activity Feed should be infinitely scrollable on the landing page instead of redirecting user to their profile page cc @aniketkatkar97 @chirag-madlani

  • When Style applied to a term or tag, it should be updated in activity feed instead of showing style json

@OnkarVO7
Copy link
Collaborator

Activity Feed does not display the knowledge center article's title

Screen.Recording.2024-05-28.at.1.43.52.PM.mov

@aniketkatkar97
Copy link
Member Author

aniketkatkar97 commented May 28, 2024

  • Old feed component in the conversation panel on entity page and alignment issue
Screenshot 2024-05-28 at 12 29 54 PM Screenshot 2024-05-28 at 12 30 42 PM

@ayush-shah
Copy link
Member

  • distinguish glossary terms and tags from each other on activity feed
    image
    image
    image

@Ashish8689
Copy link
Contributor

@mohityadav766 Needed BE support for this.

  • There are some entities with the display name along with it. And we don't have entity info in the Feed. Having the entity reference for the particular entity will help us to display the updated name for the feed.
    image (7)
    image (8)

  • For any kind of column update in the entity we don't have info about the column in the Feed data. It's hard to state the changes belong to table or column.

image image

Feed not Generating for this change event :

  • Classification re-naming and description change.
  • Tag displayName, description, re-naming, style change.
  • Removing Domain in Glossary
  • Glossary updating description and re-naming displayName
  • Glossary Term re-naming / displayName
  • Team update email, domain, owner, subscription,displayName and description

Feed generation not needed :

  • I have updated the widgets in the Persona and it created a feed as entityCreated, I don't think we should we should created any feed for this.

Need Feed info with cardSyle :

  • image
  • image
  • image
  • image
  • image
  • image

@Rupchavan Need mock for the above feeds!

@Ashish8689 Ashish8689 linked a pull request May 30, 2024 that will close this issue
9 tasks
@Ashish8689
Copy link
Contributor

Feed cardStyle for tags update in entities will come like:

  • Tags : Only for Tags update
  • GlossaryTags: Only for Glossary update
  • TagsAndGlossary: Or both the Tags and Glossary update

cc: @mohityadav766

@Ashish8689
Copy link
Contributor

  • Activity feed going from one thread to another with the same profile image sticks on another user
Screen.Recording.2024-06-04.at.11.35.57.AM.mov

@ShaileshParmar11
Copy link
Contributor

Breadcrumb for the test case should be Data quality / Test Case

image (6)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI UI specific issues
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

8 participants