Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add consistency checks for allow halving/doubling flags. closes #266 #362

Merged
merged 5 commits into from
Jun 18, 2024
Merged

add consistency checks for allow halving/doubling flags. closes #266 #362

merged 5 commits into from
Jun 18, 2024

Conversation

slayoo
Copy link
Member

@slayoo slayoo commented Jun 4, 2024

No description provided.

@slayoo slayoo requested a review from jcurtis2 June 4, 2024 15:55
@slayoo slayoo linked an issue Jun 4, 2024 that may be closed by this pull request
add consistency check ensuring that allow_halving/doubling values in AeroState instance match that passed to RunPartOpt #266
Closed
@slayoo
Copy link
Member Author

slayoo commented Jun 4, 2024 •
edited

TODO:

  • add unit tests for run_part_timestep and _timeblock

@slayoo slayoo added this pull request to the merge queue Jun 18, 2024
Merged via the queue into open-atmos:main with commit 186eced Jun 18, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcurtis2 jcurtis2 jcurtis2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@slayoo @jcurtis2