Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fractal dimension is hardcoded to be spherical #236

Open
jcurtis2 opened this issue Jul 24, 2023 · 4 comments
Open

Fractal dimension is hardcoded to be spherical #236

jcurtis2 opened this issue Jul 24, 2023 · 4 comments

Comments

@jcurtis2
Copy link
Member

We currently get around never specifying it and its not a problem due to hardcoding in spherical particles:

subroutine f_aero_data_ctor(ptr_c) bind(C)
type(aero_data_t), pointer :: ptr_f => null()
type(c_ptr), intent(out) :: ptr_c
allocate(ptr_f)
call fractal_set_spherical(ptr_f%fractal)
ptr_c = c_loc(ptr_f)
end subroutine

As of now, we do not currently read in the fractal information in run_part_opt.F90. This goes to the issue of having a near duplicate version of the code found in PartMC's main driver partmc.F90. So this will be addressed in #55 and fractal particles can be enabled by deleting Line 19 of code above.

@github-actions
Copy link

Stale issue message

Copy link

Stale issue message

Copy link

Stale issue message

@slayoo
Copy link
Member

slayoo commented May 21, 2024

compdyn/partmc#188

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants