Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable nucleation #214

Open
jcurtis2 opened this issue May 17, 2023 · 6 comments
Open

Enable nucleation #214

jcurtis2 opened this issue May 17, 2023 · 6 comments
Assignees

Comments

@jcurtis2
Copy link
Member

Currently we have nucleation not able to be enabled. This problem will most likely change/disappear when PartMC is rewritten for compdyn/partmc#184.

However to fix the issue now, RunPartOpt will need access to AeroData to modify the number of weight classes (and subsequent tests will need to be fixed to include this input.).

@jcurtis2
Copy link
Member Author

Support also probably needs to consider a longtime existing issue of what to do here: compdyn/partmc#65

PyPartMC only uses NUMMASS_SOURCE weighting (which is most efficient except in the case of nucleation enabled). This weight choice should be relaxed by passing additional details in the json input to RunPartOpt.

@github-actions
Copy link

Stale issue message

@github-actions
Copy link

Stale issue message

Copy link

Stale issue message

Copy link

github-actions bot commented Feb 5, 2024

Stale issue message

@slayoo
Copy link
Member

slayoo commented May 21, 2024

compdyn/partmc#188

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants