Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Database constraints ignored by Ontop CLI #777

Open
jindrichmynarz opened this issue Nov 14, 2023 · 1 comment
Open

Database constraints ignored by Ontop CLI #777

jindrichmynarz opened this issue Nov 14, 2023 · 1 comment

Comments

@jindrichmynarz
Copy link

Hi,

the --constraint parameter of Ontop CLI is ignored in the current version5 branch.

If I understand this comment correctly, the implicit database constraints are considered a legacy mechanism, so I would expect the --constraint parameter to be removed to indicate that it's not supported.

However, if it is expected to be supported, the CLI should use it. For example:

if (constraintFile != null) {
  configBuilder.basicImplicitConstraintFile(constraintFile);
}
@bcogrel
Copy link
Member

bcogrel commented Nov 23, 2023

Hi @jindrichmynarz, thanks for reporting this issue.

That's indeed a bug, as we are still supporting this feature even if we recommend using lenses.

Best,
Benjamin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants