Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

diff should infer intended output format from suffix #1151

Open
cmungall opened this issue Sep 25, 2023 · 1 comment
Open

diff should infer intended output format from suffix #1151

cmungall opened this issue Sep 25, 2023 · 1 comment

Comments

@cmungall
Copy link
Contributor

It would be more consistent with other behavior if diff took the default diff output format from the file suffix.

The current behavior is a bit confusing, as the default "plain" is almost idiomatic markdown; for example, doing an arbitrary diff on 2 versions of envo with -o diff.md and no --format md gives lines like this:

- SubClassOf(<ENVO:01000197>[broadleaf forest biome] ObjectSomeValuesFrom(<RO:0000056>[participates in] <ENVO:01001827>[climactic ecological succession]))

If the diff consists only of deletions, then this looks like a markdown list, the <ENVO:01000197>[broadleaf forest biome] looks kind of like a broken markdown link.

This could be considered a breaking change which we don't do, in which case I think just an additional note of caution in the docs should be sufficient to close this (I can do this if this is the preferred action)

@jamesaoverton
Copy link
Member

I think this would be a good change. The risk of breakage seems small to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants