Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements / fixes to device copyable specializations #1505

Open
danhoeflinger opened this issue Apr 16, 2024 · 1 comment
Open

Improvements / fixes to device copyable specializations #1505

danhoeflinger opened this issue Apr 16, 2024 · 1 comment
Assignees

Comments

@danhoeflinger
Copy link
Contributor

danhoeflinger commented Apr 16, 2024

@MikeDvorskiy and I discussed some issues with device copyable. He is working on a PR to resolve them.

The 2 issues we found which need addressing are:

  1. Types with non-type template parameters (transform_reduce), can not match variadic typename pack
  2. Types which include template parameters which should not be checked (anything with an ExecutionPolicy, which includes sycl::queue for device policies, which is not device copyable)

Also, with these changes in mind, we are looking to embed the device copyable specialization in with the type definitions. This makes things more clear, and reduces the maintenance burden of maintaining extra forward declarations in sycl_traits.h

@MikeDvorskiy
Copy link
Contributor

There is a prototype to fix the issue: #1513
It is we can do the best on the current moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants