-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nested structured config validation #1019
Comments
This is a bug. Thanks very much for the report, @djkawa! |
My attempt: omry:omegaconf:v2.3.0...bzczb:omegaconf:8e69077aca715f57d0f028c0dc1421d643ed8018 |
@bzczb your patch looks like a good start. We'd want to (1) add tests based on the OP's example and (2) add tests to make sure that the The "wrong error message" you mentioned might not be a big deal. |
Hi folks,
Not sure if it’s a bug or just not supported, I cannot opine for sure from the docs, feel free to clarify. I have noticed that the validation on structured configs does not go deeper than one level when using a nested dataclass.
While the first level of nesting works great, I was expecting the merge to fail because of the object named
did_not_fail_validation
. And even if the wrong yaml was fixed, I would have expected thenot_typed
object to be aDeeplyNestedConf
.Looking forward to knowing your thoughts.
Additional context
The text was updated successfully, but these errors were encountered: