Bug: Emojis names aren't detected after ambiguous colon matches

[goodjun]

Colon string conversion failure.

like this:

var emoji = require('node-emoji');

var text = emoji.emojify('06:30:sad:')

// text should is '06:30😞', but is '06:30:sad:'

[JoshuaKGoldberg]

Heh, this is a tricky one. The library detects the :30: as the potential emoji name, and doesn't see the :sad:. This is a behavior of JS regular expressions - they'll skip a match if it overlaps with a previous match in this way:

node-emoji/src/emojify.ts

Line 28 in ff34dce

return input.replace(/:([a-zA-Z0-9_\-+]+):/g, part => {

I think it'd be reasonable to try to also capture for this logic... as long as the implementation doesn't get too complex. And it should probably also work for consecutive overlaps, like 00:06:30:sad.