Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some editors report edits when blurred with no change, others don’t #4484

Open
JanRomero opened this issue Apr 26, 2024 · 0 comments
Open
Labels
Possible Bug A possible bug that needs investigation

Comments

@JanRomero
Copy link

Greetings,

I’m trying to send only edited rows back to the server, but I’ve found just clicking around in the table without changing anything sometimes marks cells as edited. Apparently it depends on the editor the cell uses.

This behaviour also seems to vary between browsers. Here’s a fiddle that lists all edited rows whenever you click inside the table:
https://jsfiddle.net/g5tdomky/

Note how in Edge, edits are reported as soon as a tickCross or list editor is opened and closed, even though no changes have been made. The same behaviour is not true for the standard text input in the Name column. In Firefox, tickCross behaves correctly, but list doesn’t. I don’t know about other editors.

Note also how the cellEdited event (correctly) doesn’t fire unless the values are actually changed. Otherwise I could use that to check against the initial value and call cell.clearEdited() accordingly.

Tabulator Info
Tabulator 6.2.0

Working Example
https://jsfiddle.net/g5tdomky/

Expected behavior
Cells whose value matches the initial value should not be marked as edited, imho. I feel like it should behave the same way as canceling the edit.

Desktop
Firefox 125
Edge 124

Thank you!

@JanRomero JanRomero added the Possible Bug A possible bug that needs investigation label Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Possible Bug A possible bug that needs investigation
Projects
None yet
Development

No branches or pull requests

1 participant