BasicVertical renderer restores scroll position in rerenderRows #4481
Conversation
|
How does this resolve the issue? In basic render mode the table generally doesn't have a height set and so the scroll is not on the table element but usually on the page body and it is the redrawing of the content that results in the loss of scroll position. Which changing the internal scroll position of the table will not resolve? Cheers Oli |
olifolkerd
added
the
PR Needs Work
|
It resolves it when the table element does have a scroll position. Such as when the height is explicitly set like in the example in the linked issue. Only way I can think to resolve your scenario with the page itself scrolling would be to temporarily add some padding or something before the rows are removed so the total height doesn't change. I'm however unsure if that would just cause more performance issues with the browser redrawing. (I am not well versed in when/what causes browser re-renders) I suppose I'm also a bit at a loss why adding new rows to the end should end up with the basic renderer clearing and recreating all the rows. Perhaps there should be a method on renderers to update/render specific rows (or just new ones)? This would allow the basic and/or virtual renderer to determine if it needs to draw/add elements as necessary. Is there an issue with setting the scroll position to its previous value after rendering the rows? |
Makes the
BasicVerticalrenderer remember the scroll position whenrerenderRowsis called so it can be restored after clearing and rendering the rows.This fixes #4469 when Progressive Scrolling is used with the Basic renderer, the table scrolls back to the top when a new page is loaded. This is because all rows are cleared and re-added.
Side note/Suggestion: The documentation at https://tabulator.info/docs/6.2/render#vertical for
rerenderRowssays that the rows should be cleared AND rendered before the callback is called. However the current code for both the Basic and Virtual renderers clear then call the callback and then render the rows. Might be prudent to update the documentation to reflect this.