Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leak when using dataTree module and replaceData #4454

Open
panofr opened this issue Apr 4, 2024 · 0 comments
Open

Leak when using dataTree module and replaceData #4454

panofr opened this issue Apr 4, 2024 · 0 comments
Labels
Possible Bug A possible bug that needs investigation

Comments

@panofr
Copy link

panofr commented Apr 4, 2024

Describe the bug
When using "replaceData" many times with an heavy dataload on Tabulator 5.x and 6.2 with dataTree activated, Chrome crashed sometimes out of memory.
With a bit of investigation, I found that when calling "replaceData", old rows are deleted (wipe), but expanded row's cells aren't.
So Tabulator's table.columnManager stills reference old detached DOM cells, and memory is growing without limit.

The problem occurs only if some row are expanded. If I don't have any dataTree or if I force all row to be 'closed' this leak doesn't occur.

Tabulator Info
6.2

Working Example
I've made an super simple example:
https://jsfiddle.net/Lionel_Anyware/nmsk6jq5/6/

To Reproduce
A step by step guide to recreate the issue in your JS Fiddle or Codepen:

  1. Go to the fiddleJs
  2. Click on replaceData
  3. See that number of cell referenced is increasing each time replaceData is called.

Expected behavior
The dataTree's children cells (if I understand correctly) should be deleted as well as rows.Cells when calling replaceData

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: Windows 10/11
  • Browser: Chrome
  • Version: 123

Additional context
Add any other context about the problem here.

@panofr panofr added the Possible Bug A possible bug that needs investigation label Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Possible Bug A possible bug that needs investigation
Projects
None yet
Development

No branches or pull requests

1 participant