-
-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Indentation-sensitive grammar forgets consumed dedents #465
Comments
FYI this patch solves the issue for me: And this one provides some more debugging information: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi, I'm using Ohm v17.1.0 to build a whitespace-sensitive grammar using the experimental indentation support. I am struggling to get the following MVE grammar to correctly parse the example:
And the example:
The parse fails at line 5 col 5 with
Expected a dedent, a space, or "key:"
, which is weird because it should be able to consume a dedent, orkey:
if it has just consumed one. After banging my head against the desk for a while, I've stepped through the parsing code and whilst it does consume the dedent, when it returns to the same position to continue the parse it seems to still be expecting one. AFAICS the result of attempting to parse at this position is memoized when it should not be, because the memoized version does not take into account the consumed dedent.Specifically, if I comment out this line which resets memoization for a match state that has it enabled
ohm/packages/ohm-js/src/pexprs-eval.js
Lines 277 to 279 in 39ccead
...the parse works as expected.
However, I'm not really sure why this line is here so not sure if I've found a bug or have just two-wrongs-make-a-righted myself.
I'd be happy to work on and submit a patch for this, but I could do with a positive confirmation that this is a problem, and pointers to any other areas that I might need to change as result. No doubt it's all more complicated than I understand at the moment! Thanks!
The text was updated successfully, but these errors were encountered: