New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This no longer supports Fish 2.2.0 #934
Comments
cr0t
added a commit
to cr0t/dotfiles
that referenced
this issue
Jan 22, 2024
The main repository seems abandoned for the last couple of years: https://github.com/oh-my-fish/oh-my-fish According to this [issue](oh-my-fish/oh-my-fish#934) written by faho – one of the top contributors to fish shell itself – Oh My Fish doesn't support the latests versions anymore. Goodbye.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Since 029a675, this uses the
string
builtin in omf.packages.install:https://github.com/oh-my-fish/oh-my-fish/blame/d427501b2c3003599bc09502e9d9535b5317c677/pkg/omf/functions/packages/omf.packages.install.fish#L22
That was only introduced in fish 2.3.0 (and it's possible this specific usage only worked in an even later version), which means this won't work in fish 2.2.0 - unlike the badge in the README claims.
It is possible to replace this with
grep
, but frankly, given that fish 2.3.0 is 7 years old, and that 67% of all commits to fish happened since then, I don't believe it is a good use of the already very limited time of the omf contributors.Specifically, this will be awkward to new contributors because they'll very likely not know how to support a version that old, and how you would write good fish script has changed a fair bit since then -
string
,argparse
,math
, ...So I would suggest increasing the minimum supported version. See repology for which fish versions are in use by distributions, where you'll find very few still in-support versions that have fish < 3.0.
And see this handy table for how many commits there have been since each release (excluding patch releases):
The text was updated successfully, but these errors were encountered: