-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: zap library leaking into binaries #1242
Labels
bug
Something isn't working
Comments
It seems that generated code imports
Line 8 in d1f597e
Line 6 in d1f597e
Not sure if we can fix it without breaking v1 compatibility. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What version of ogen are you using?
v1.1.0
Can this issue be reproduced with the latest version?
Yes
What did you do?
This is an extremely minor bug, but it's worth noting down if anyone wants to look into it.
I ran
gsa
on my API binaries when I noticed thatzap
was being imported into my project. I think it's leaking into the API binaries via theogen/jsonschema
library (not sure) and adding ~40kb
to all binaries if you do not usezap
.ogen/jsonschema/external.go
Line 57 in e147d5e
It's not high priority, but I think any optimizations like this will help in resource constrained environments.
What did you expect to see?
zap
should not be present in the library.What did you see instead?
The text was updated successfully, but these errors were encountered: